-
Notifications
You must be signed in to change notification settings - Fork 16
Add summary statistics info #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tarcisiozf
merged 27 commits into
bitfinexcom:staging
from
ZIMkaRU:feature/add-summary-statistics-info
Oct 3, 2025
Merged
Add summary statistics info #485
tarcisiozf
merged 27 commits into
bitfinexcom:staging
from
ZIMkaRU:feature/add-summary-statistics-info
Oct 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update bfx-report-ui sub-module to master
elvis-poggi
approved these changes
Oct 3, 2025
tarcisiozf
approved these changes
Oct 3, 2025
This was referenced Oct 7, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds summary
statisticsinfo intogetSummaryByAssetendpointBasic changes:
allFeesUsdtaken from the ledgers with201, 204, 207, 222, 224, 228, 241, 243, 251, 254, 255, 258, 905categories to be used in UI asFees occurredfielddepositsWithdrawalsUsdto be used in UI asDeposits/WithdrawalsfieldplUsdto be used in UI asProfitfieldvolatilityPercto be used in UI asVolatilityfieldsharpeRatioto be used in UI asSharpe RatiofieldsortinoRatioto be used in UI asSortino RatiofieldmaxDrawdownPercto be used in UI asMax DrawdownfieldisUnrealizedProfitExcludedflag, it's the same flag that we use forAccount BalanceandProfitschartsAlso for the
BalanceandVolumefields of the statistics can be used the already done response of the samegetSummaryByAssetendpoint:volumeUsdbalanceUsdRequest example:
{ "auth": { "token": "auth-token" }, "method": "getSummaryByAsset", "params": { "start": 1727775188000, "end": 1759397588266, "isUnrealizedProfitExcluded": true // or false, the same flag that we use for `Account Balance` and `Profits` charts } }Response example:
{ "jsonrpc": "2.0", "result": { "summaryByAsset": [ { "currency": "LEO", "balance": 1.23, "balanceUsd": 32.1, "balanceChange": 0, "balanceChangePerc": 0, "volume": 0, "volumeUsd": 0, "tradingFees": 0, "marginFundingPayment": 0 }, // ... ], "total": { "balanceUsd": 32.1, "balanceChangeUsd": 32.1, "balanceChangePerc": 1.23, "volumeUsd": 32.1, "tradingFeesUsd": 1.23, "allFeesUsd": 12.3, "depositsWithdrawalsUsd": -12.3, "plUsd": 12.3, "volatilityPerc": 12.3, "sharpeRatio": 1.23, "sortinoRatio": 1.23, "maxDrawdownPerc": 12.3 } }, "id": null }