-
Notifications
You must be signed in to change notification settings - Fork 16
Rework sync schema model usage to use new model interface #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tarcisiozf
merged 29 commits into
bitfinexcom:staging
from
ZIMkaRU:refactoring/rework-sync-model-usage-to-use-new-model-interface
Jun 9, 2025
Merged
Rework sync schema model usage to use new model interface #461
tarcisiozf
merged 29 commits into
bitfinexcom:staging
from
ZIMkaRU:refactoring/rework-sync-model-usage-to-use-new-model-interface
Jun 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcisiozf
approved these changes
Jun 5, 2025
elvis-poggi
approved these changes
Jun 9, 2025
This was referenced Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks sync schema model usage to use the new model interface implemented in the previous PR #459
It speeds up the work by avoiding the usage of
cloneDeepfn based onJSON.parse(JSON.stringify(obj))for the modelsThe PR is part of the refactoring and doesn't have the changes of the main logic and functionality