Improve fetching opened positions for balance report #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves fetching
opened positionsfor the balance reportwe use the positions snapshot endpoint (it's daily snapshots) for getting opened positions and then calc p/l using 1D candles
but for the ending point of the balance chart, it does not give accurate results (if it's the middle of the day) and if we try to compare it with
Active Positionssection we can see slightly different resultsso as a solution, we can try to fetch opened positions for the ending point of the balance chart from API (as we do for
Active Positionssection). But if API request is not successful then fetch the positions snapshot from DB