check if is electron app #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release version to master
691dbb7 to
ea191e5
Compare
ZIMkaRU
suggested changes
Mar 7, 2025
Member
ZIMkaRU
left a comment
There was a problem hiding this comment.
can we set "isHosted": false in config as true
to simplify the setup process on the server
by default, we should aim to provide configs that are workable on the host
and this one:
if (!isElectronjsEnv) {
return {
isSaveLocaly: false
}
}remove as it breaks docker/terraform workflow in bfx-reports-framework
just config is a good option
Member
|
could you please change the merge branch to |
elvis-poggi
approved these changes
Mar 12, 2025
This was referenced Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.