这是indexloc提供的服务，不要输入任何密码
Skip to content

Extend error logs for sync proc #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Extend error logs for sync proc #360

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ac0f68
Merge pull request #358 from bitfinexcom/staging
prdn Mar 20, 2024
adf35fa
Extend error logs for sync proc
ZIMkaRU Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions workers/loc.api/responder/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ const _getErrorWithMetadataForNonBaseError = (args, err) => {
return err
}

const _getErrorMetadata = (args, err) => {
const _getErrorMetadata = (args, err, name) => {
const errWithMetadata = _getErrorWithMetadataForNonBaseError(args, err)
_addStatusMessageToErrorMessage(errWithMetadata)
const {
Expand Down Expand Up @@ -178,8 +178,10 @@ const _getErrorMetadata = (args, err) => {
data: extendedData
}
)
const serializedError = _prepareErrorData(error, name)
Object.assign(error, { serializedError })

return { code, message, data, error }
return { code, message, data, error, serializedError }
}

const _logError = (loggerArgs, err) => {
Expand All @@ -195,21 +197,22 @@ const _logError = (loggerArgs, err) => {
)
const {
code,
error
} = _getErrorMetadata(args, err)
error,
serializedError
} = _getErrorMetadata(args, err, name)

_emitEventByWs(loggerArgs, error)

if (
code !== 500 ||
shouldNotBeLoggedToStdErrorStream
) {
logger.debug(_prepareErrorData(error, name))
logger.debug(serializedError)

return
}

logger.error(_prepareErrorData(error, name))
logger.error(serializedError)
}

const _emitEventByWs = (emitterArgs, error) => {
Expand Down