这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix api error handling #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 21, 2023
Merged

Fix api error handling #300

merged 5 commits into from
Jun 21, 2023

Conversation

@ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Jun 21, 2023

This PR fixes bfx api error handling

Basic changes:

  • Increases endpoint call repetitions to 100 for rate limit err
  • Resolves case sensitive for bfx api err detection
  • Adds status message to error message
  • Improves rate limit error message for better UI/UX
  • Adds node-fetch timeout error tester
    Screenshot from 2023-06-21 10-46-08

ezewer
ezewer approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@prdn prdn merged commit 99826e2 into bitfinexcom:beta Jun 21, 2023
This was referenced Jun 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezewer ezewer ezewer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZIMkaRU @ezewer @prdn