Prevent proxy all HTML of bfx api error #299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents proxying all HTML of the bfx api error
In some cases, the bfx api may respond just HTML instead of expected json in the raw body https://github.com/bitfinexcom/bfx-api-node-rest/blame/master/lib/rest2.js#L166
For example: maintenance mode, nginx 502
Bad Gatewayerror, 403Forbiddenfor the staging server, check the screenshot:The idea is:
titletag to use as a description of the errorBasic changes:
forbiddenresource error testerforbiddenresource errorRequest example:
{ "auth": { "apiKey": "api_key", "apiSecret": "api_secret" }, "method": "verifyUser" }Response example:
{ "jsonrpc": "2.0", "error": { "code": 403, "message": "Forbidden", "data": { "bfxApiErrorMessage": { "bfxApiStatus": 403, "bfxApiStatusText": "Forbidden", "bfxApiRawBodyCode": "Code is not abailable", "isBfxApiRawBodyResponseHtml": "Yes", "bfxApiRawBodyResponse": "Access denied | api.staging.bitfinex.com used Cloudflare to restrict access" } } }, "id": null }Error logging examples: