这是indexloc提供的服务，不要输入任何密码
Skip to content

(improvement) Tax report: notify about inaccurate calculations #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
May 6, 2025
Merged

(improvement) Tax report: notify about inaccurate calculations #926

merged 31 commits into from
May 6, 2025

Conversation

@alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Apr 25, 2025 •
edited
Loading

Task: https://app.asana.com/0/home/1198734617779732/1209985641707822

Description:

  • Implements user notifications about inaccurate Tax Report calculations due to delisted tokens
- We should notify the user about the calculation inaccuracy 

- If ‘ok’ - show report,  if ’decline’ - show empty table
  • Syncs staging with the latest master

Preview:

tax-delisted-tokens-warn-flow.mov

 
tax-delisted-tokens-warning-prev

Depends on:

ezewer and others added 30 commits April 21, 2025 22:19
@ezewer
Merge pull request bitfinexcom#925 from bitfinexcom/staging
67f2bb3 
Release version to master
@alexstotsky
Adjust tax report generation success handling
fccede4
@alexstotsky
Update tax report constants
ee82b41
@alexstotsky
Implement showCalcPrecisionModal action
263d3aa
@alexstotsky
Extend handleTaxTrxReportGenerationCompleted sagas handling cases
49063b9
@alexstotsky
Actualize constants naming
09ec20f
@alexstotsky
Update tax report actions
514ccbb
@alexstotsky
Implement calc precision modal handling case in the tax reducers
7f8ce26
@alexstotsky
Improve delisted ccys handling flow in sagas
2c78724
@alexstotsky
Add getTransactionsShowCalcPrecisionModal selector
9a5824d
@alexstotsky
[wip]Tax calculations precision modal
59c7164
@alexstotsky
Add tax precision modal styling
d25431f
@alexstotsky
Add tax precision modal to the main
1da14c0
@alexstotsky
Actualize styles import
68f72f2
@alexstotsky
Add tax precision warning key/description
77e8519
@alexstotsky
Implement getTransactionsDelistedCurrencies selector
362f361
@alexstotsky
Fix calc modal selector
2e317d0
@alexstotsky
Add modal btns keys/descriptions
8bb76b1
@alexstotsky
Remove redundant code and update export
39ffacd
@alexstotsky
Rework and optimize tax precision modal
e639a02
@alexstotsky
Actualize precision modal message and classnames
f88dd97
@alexstotsky
Update styling
505df42
@alexstotsky
Adjust dialog spacing
c27306e
@alexstotsky
Add tax dialog to the main
af9344e
@alexstotsky
Improve calc precision messages
eb59004
@alexstotsky
Implement deslisted tokens handling in precision modal
0b15619
@alexstotsky
Fix provided tokens var naming
eba29dc
@alexstotsky
Implement submit/decline events handling
5854977
@alexstotsky
Optimize precision modal handlers and cleanup
ab79676
@alexstotsky
Update locales
a21a2d2
@alexstotsky alexstotsky changed the title (improvement) Tax report: notify the user about inaccurate calculations (improvement) Tax report: notify about inaccurate calculations Apr 25, 2025
@alexstotsky alexstotsky marked this pull request as ready for review April 25, 2025 11:34
@alexstotsky alexstotsky mentioned this pull request May 2, 2025
Merged
1 task
ezewer
ezewer approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit a18a3a6 into bitfinexcom:staging May 6, 2025
@alexstotsky alexstotsky deleted the notify-about-inaccurate-tax-calcs branch May 7, 2025 11:53
This was referenced May 13, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezewer ezewer ezewer approved these changes

@elvis-poggi elvis-poggi elvis-poggi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexstotsky @ezewer @elvis-poggi