这是indexloc提供的服务,不要输入任何密码
Skip to content

(feature) Electron app menu integration #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 104 commits into from
Feb 18, 2025

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Feb 14, 2025

Task: https://app.asana.com/0/1163495710802945/1205837142472301/f

Description:

  • Implements Electron app menu bar and corresponding functionality in the UI title instead of the native one

This is very useful as it saves overall space and at the same time constantly displays the menu and does not require the user to press the Alt key to display it (as the practice has shown, because of the last one, many inexperienced users do not even know about the existence of menu functions).

Available for the Windows and Linux app users. On the Mac we have to hide the menu in the UI and show the native electron menu bar due to some MacOS specifics, it's impossible to have proper menu item control from the UI.


Preview:

electron-menu-prev

 

electron-menu-flow.mov

Depends on:

@alexstotsky alexstotsky marked this pull request as ready for review February 14, 2025 11:54
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit 19a981c into bitfinexcom:staging Feb 18, 2025
@alexstotsky alexstotsky deleted the add-electron-menu-to-ui branch February 18, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants