-
Notifications
You must be signed in to change notification settings - Fork 21
(feature) Electron app menu integration #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ezewer
merged 104 commits into
bitfinexcom:staging
from
alexstotsky:add-electron-menu-to-ui
Feb 18, 2025
Merged
(feature) Electron app menu integration #898
ezewer
merged 104 commits into
bitfinexcom:staging
from
alexstotsky:add-electron-menu-to-ui
Feb 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elvis-poggi
approved these changes
Feb 14, 2025
ezewer
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This was referenced Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: https://app.asana.com/0/1163495710802945/1205837142472301/f
Description:
Electron
app menu bar and corresponding functionality in the UI title instead of the native oneThis is very useful as it saves overall space and at the same time constantly displays the menu and does not require the user to press the
Alt
key to display it (as the practice has shown, because of the last one, many inexperienced users do not even know about the existence of menu functions).Available for the
Windows
andLinux
app users. On theMac
we have to hide the menu in the UI and show the native electron menu bar due to someMacOS
specifics, it's impossible to have proper menu item control from the UI.Preview:
electron-menu-flow.mov
Depends on: