这是indexloc提供的服务，不要输入任何密码
Skip to content

(improvements) Tax report generation progress #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 30, 2024
Merged

(improvements) Tax report generation progress #837

merged 21 commits into from
Jul 30, 2024

Conversation

@alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Jul 26, 2024 •
edited
Loading

Tasks:
https://app.asana.com/0/1163495710802945/1207814574337730/f
https://app.asana.com/0/1163495710802945/1207293745238641/f

Description:

  • Implements generation progress representation for the new Tax Report according to the latest improvement proposals
  • Implements notification on Tax Report generation finish

Preview:

tax-genration-in-progress

 
tax-generation-success

Depends on:

alexstotsky added 21 commits July 26, 2024 07:09
@alexstotsky
Improve tax report initial fetch flow
3fff5b4
@alexstotsky
Add report generation success key/description
a22fd5d
@alexstotsky
Implement notification on tax report generation success
5d7197f
@alexstotsky
Add ws tax report generation progress const
3ccc683
@alexstotsky
Add pogress setter action and constant
9008d18
@alexstotsky
Implement handleTaxTrxReportGenerationProgress saga
75b6c51
@alexstotsky
Add progress handling reducer cases, update init state
e42350a
@alexstotsky
Implement getTransactionsGenerationProgress selector
852f4a2
@alexstotsky
[wip] Tax report loader section
a83d5e3
@alexstotsky
Add tax report loader styling
d311d0d
@alexstotsky
Add loading section to the tax report
659a54a
@alexstotsky
Implement progress value handling and providing
e91b828
@alexstotsky
Improve spinner content validation check
f47c3d1
@alexstotsky
Adjust loader content styling and positioning
e503e62
@alexstotsky
Add tax gen notice keys/descriptions
729d139
@alexstotsky
Implement tax report generation note
ca9f192
@alexstotsky
Improve spinner elements composition
48b4711
@alexstotsky
Adjust loading section styling
b3db6f6
@alexstotsky
Minor fix
a7b5f43
@alexstotsky
Improve init generation flow
d5b4fce
@alexstotsky
Minor tweak
40f0ecd
@alexstotsky alexstotsky changed the title [WIP] (improvements) Tax report generation progress (improvements) Tax report generation progress Jul 26, 2024
@alexstotsky alexstotsky marked this pull request as ready for review July 26, 2024 10:34
ezewer
ezewer approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit e1c1bed into bitfinexcom:staging Jul 30, 2024
@alexstotsky alexstotsky deleted the tax-report-progress branch July 31, 2024 10:03
This was referenced Jul 31, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezewer ezewer ezewer approved these changes

@elvis-poggi elvis-poggi elvis-poggi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexstotsky @ezewer @elvis-poggi