这是indexloc提供的服务，不要输入任何密码
Skip to content

(improvements) Summary sections loading states #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 53 commits into from
Feb 14, 2024
Merged

(improvements) Summary sections loading states #768

merged 53 commits into from
Feb 14, 2024

Conversation

@alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Feb 7, 2024 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1206056743460083/f

Description:

  • Enhances representation of the app Summary sections loading states according to the latest design updates
  • Adds showing loading states for them during initial sync according to this proposal

Before:

summary-loading-before.mov

After:

summary-loading-after.mov

Initial synchronization:

init-sync+loading.mov

@alexstotsky alexstotsky changed the title [WIP] (improvements) Summary sections loading states (improvements) Summary sections loading states Feb 7, 2024
@alexstotsky alexstotsky marked this pull request as ready for review February 7, 2024 11:37
elvis-poggi
elvis-poggi reviewed Feb 7, 2024
View reviewed changes
elvis-poggi
elvis-poggi approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@elvis-poggi elvis-poggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, left a comment about small improvement

@alexstotsky alexstotsky mentioned this pull request Feb 7, 2024
Closed
3 tasks
@alexstotsky alexstotsky force-pushed the improve-summary-loading-state branch from 6ddd7dd to ffa7bb8 Compare February 12, 2024 12:21
@alexstotsky
Implement loading placeholder
0fec1b0
@alexstotsky
Implement shimmering effect
39b4265
@alexstotsky
Update animation background
76609fa
@alexstotsky
Implement loader width randomizer dependent on the base witdh
f8be661
@alexstotsky
Adjust default color shimmering
bbd4f47
@alexstotsky
Update loader styles import
b326dcc
@alexstotsky
Improve loading placeholder sizing
25e4e11
@alexstotsky
Implement is strong prop handling, upd prop-types
40a588c
@alexstotsky
Ceanup
01861ef
@alexstotsky
Adjust strong and default loaders styling
80e88d9
@alexstotsky
Add default and strong placeholders
6e3afb6
@alexstotsky
Lint fix and memoize
fb0fd71
@alexstotsky
Fix warning
3b3aab4
@alexstotsky
Implement preloading state for chart value
a3ad3bb
@alexstotsky
Add preloading to chart value percents
bcc98eb
@alexstotsky
Rework chart values placheolders
b92db6d
@alexstotsky
Adjust chart placheolders styling
1ce39b4
@alexstotsky
Improve placheolders positioning
93b0668
@alexstotsky
Update styling
e0c7139
@alexstotsky
[wip] Chart data preloading state
8bf1a13
@alexstotsky
Update chart constants
57ac5fe
@alexstotsky
Update acc balance chart aspect
e83fe02
@alexstotsky
Implement account fees section preloaders
2b193d0
@alexstotsky
Improve fees cells values styling
59b9f74
@alexstotsky
Update getFeesColumns configuration
d76514b
@alexstotsky
Adjust app value chart configuration
8349be6
@alexstotsky
Cleanup
3d5e8de
@alexstotsky
Rework loading state handling for the account fees
dce308b
@alexstotsky
Lint fix
6515512
@alexstotsky
Adjust accs fees placholders config
5899a30
@alexstotsky
Improve cells items styling
1131ef0
@alexstotsky
Adjust value aspect ratio
9d4fe4a
@alexstotsky
Implement sum by asset preloaders config
8e68d7a
@alexstotsky
Rework summary by asset preloading state handling
bde3237
@alexstotsky
Adjust sum by asset preloading state rows
9a399ae
@alexstotsky
Lint fix
af1a04e
@alexstotsky
Improve no data case checking
66c136d
@alexstotsky
Add getIsFirstSyncing selector
661cf1b
@alexstotsky
Implement loading state setting for fees on first syncing
4d51c03
@alexstotsky
Implement loading state setting for account balance on first syncing
7702e6c
@alexstotsky
Improve summary by asset loading state handling
630c187
@alexstotsky
Adjust styling
3df5463
@alexstotsky
Extract percent fee cell for better reusability
67f5e99
@alexstotsky
Update columns config
25da8dd
@alexstotsky alexstotsky force-pushed the improve-summary-loading-state branch from ffa7bb8 to 25da8dd Compare February 12, 2024 12:38
@alexstotsky
Copy link
Contributor Author

alexstotsky commented Feb 12, 2024

Note: synced with the latest master/staging, without any additional changes from the last review

ezewer
ezewer approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@ezewer ezewer merged commit 1a0920a into bitfinexcom:staging Feb 14, 2024
@alexstotsky alexstotsky deleted the improve-summary-loading-state branch February 14, 2024 09:10
This was referenced Feb 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezewer ezewer ezewer approved these changes

@elvis-poggi elvis-poggi elvis-poggi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexstotsky @ezewer @elvis-poggi @prdn