这是indexloc提供的服务，不要输入任何密码
Skip to content

(feature) Add GTM tracking #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 85 commits into from
Jan 30, 2024
Merged

(feature) Add GTM tracking #762

merged 85 commits into from
Jan 30, 2024

Conversation

@alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Jan 26, 2024 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1206077419367370/f

Description:

  • Implements Google Tag Manager support for the Reports and events tracking with the following configuration:
Send click events for all buttons, nav items & tabs, format example

dataLayer.push({
  event: 'click', // same for all clicks
  label: 'Trades' // text of the button
  area_source: 'Tab' // "Tab" or "Navigation", in case of normal button omit this property
})

Depends on:

@alexstotsky
Actualize ib-js-util-base version
32969cb
@alexstotsky
Replace lodash isObject usage
ba73ebd
@alexstotsky
Add bfxuilib to the reports dependencies
bf2fe9c
@alexstotsky
Implement loadAnalyticsIfCookiesAccepted for web mode
4d86480
@alexstotsky
Implement reusable gtm event tacker
6d3d14e
@alexstotsky
Add initGoogleTag description for web/app cases
bf334e7
@alexstotsky
Optimize framework mode check
05f3f37
@alexstotsky
Implement navigation sub-sections tracking
652dac6
@alexstotsky
Implement nav-switcher tabs tracking
ed05532
@alexstotsky
Implement sections switcher tabs tracking
4575008
@alexstotsky
Implement nav menus event tracking
a705d4e
@alexstotsky
Update bfxuilib to the latest
2df6f74
@alexstotsky
Actualize google tag initialization flow
77f8780
@alexstotsky
Implement auth event tracking
7fd820e
@alexstotsky
Add sign-up events tracking
a3adc62
@alexstotsky
Add sign-in events tracking
6740102
@alexstotsky
Implement password recovery events tracking
6fa5ecc
@alexstotsky
Add acc menu event tracking
2067bd6
@alexstotsky
Update sign-in events tracking
2bda25b
@alexstotsky
Add sub-accs event tracking
5986664
@alexstotsky
Update acc menu event tarcking, unify dialogs toggling
9c23674
@alexstotsky
Add sync mode events tracking
f177b60
@alexstotsky
Implements query mode events tracking
dd8a4a9
@alexstotsky
Add hamburger menu event tracking
738abb6
@alexstotsky
Add logout event tracking
e439559
@alexstotsky
Add export navigation tracking
fb6d48f
@alexstotsky
Update tov nav event tracking
a9e97dd
@alexstotsky
Add pref btns events tracking
c7a8e02
@alexstotsky
Add theme switching tracking
824d6bc
@alexstotsky
Add timezone picker event tracking
ce04bac
ezewer
ezewer requested changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stopped review here as this is blocking.

@alexstotsky alexstotsky marked this pull request as draft January 29, 2024 11:43
@alexstotsky alexstotsky marked this pull request as ready for review January 29, 2024 11:57
@alexstotsky alexstotsky requested a review from ezewer January 29, 2024 12:01
ezewer
ezewer requested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request, rest looks good!

@alexstotsky alexstotsky requested a review from ezewer January 30, 2024 08:41
ezewer
ezewer approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ezewer ezewer merged commit c61cdb9 into bitfinexcom:staging Jan 30, 2024
@alexstotsky alexstotsky deleted the add-gtm-tracking branch January 30, 2024 13:12
This was referenced Jan 31, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezewer ezewer ezewer approved these changes

@elvis-poggi elvis-poggi elvis-poggi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexstotsky @ezewer @elvis-poggi