这是indexloc提供的服务，不要输入任何密码
Skip to content

(improvement) Spot trades pairs removal #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 19, 2024
Merged

(improvement) Spot trades pairs removal #786

merged 10 commits into from
Mar 19, 2024

Conversation

@alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Mar 9, 2024 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1206692695126103/f

Description:

  • Allows all pairs removal at the Market History / Spot section according to the latest UX improvement proposals
This is a little clunky from a UX perspective, the user first needs to add another pair 
before the user can remove the current one. 
We should allow the user to remove the current pair and display an empty 
table that says "No history to display".

Before:

spot-rm-pairs-before.mov

After:

spot-rm-pairs-after.mov

Depends on:

@alexstotsky alexstotsky changed the title [WIP] (improvement) Spot trades pairs removal (improvement) Spot trades pairs removal Mar 11, 2024
@alexstotsky alexstotsky marked this pull request as ready for review March 11, 2024 10:36
ezewer
ezewer approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ezewer ezewer merged commit 6d5eb65 into bitfinexcom:staging Mar 19, 2024
@ZIMkaRU ZIMkaRU mentioned this pull request Mar 20, 2024
Merged
@alexstotsky alexstotsky deleted the allow-pair-rm4spot branch March 20, 2024 09:42
@ZIMkaRU ZIMkaRU mentioned this pull request Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezewer ezewer ezewer approved these changes

@elvis-poggi elvis-poggi elvis-poggi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexstotsky @ezewer @elvis-poggi @prdn