这是indexloc提供的服务，不要输入任何密码
Skip to content

(improvement) Improve port lookup #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 7, 2023
Merged

(improvement) Improve port lookup #630

merged 18 commits into from
Apr 7, 2023

Conversation

@alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Apr 3, 2023 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1204112876872708/f

Description:

  • Implements logic for injection and usage of customizable ports for API_URL and WS_ADDRESS if available on electronLoad custom event in the framework mode
  • Syncs beta with the latest master

Depends on:

prdn and others added 18 commits March 15, 2023 10:53
@prdn
Merge pull request bitfinexcom#621 from bitfinexcom/beta
88ad077 
Release version to master
@prdn
Merge pull request bitfinexcom#625 from bitfinexcom/beta
571420a 
Release version to master
@prdn
Merge pull request bitfinexcom#627 from bitfinexcom/beta
df4eccf 
Send trades and symbols patch to production
Fix TEST symbols mapping
541a11a
@ezewer
Revert "Send trades and symbols patch to production"
1da9edd
Fix symbol selector width
dc73ba5
@prdn
Merge pull request bitfinexcom#629 from ezewer/revert-627-beta
a96c064 
Revert "Send trades and symbols patch to production"
@prdn
Merge pull request bitfinexcom#628 from alexstotsky/fix-pairs
f33cd36 
(fix) TEST symbols mapping
Update base constants
a2bf2b2
Add setApiPort action
b9b3057
Implement custom api port handling case in the base reducers
9120908
Implement setting apiPort in handleElectronLoad if available
c8431d6
Add getCustomApiPort selector
722d764
Implement getApiUrl helper
769e0f3
Implement getApiUrlFromStore util
8028fd8
Enhance fetch call utils to support customizable api urls
08af9b6
Add getWsAddress helper
9ffdd53
Implement customizable ws address usage support
3c80241
@alexstotsky alexstotsky marked this pull request as ready for review April 3, 2023 13:31
ezewer
ezewer approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@prdn prdn merged commit d8fb33c into bitfinexcom:beta Apr 7, 2023
@alexstotsky alexstotsky deleted the improve-port-lookup branch April 10, 2023 10:19
This was referenced Apr 12, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezewer ezewer ezewer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexstotsky @ezewer @prdn