这是indexloc提供的服务，不要输入任何密码
Skip to content

(feature) Go to a specific date on the candles chart #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 73 commits into from
Jun 24, 2022
Merged

(feature) Go to a specific date on the candles chart #527

merged 73 commits into from
Jun 24, 2022

Conversation

@alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Jun 19, 2022 •
edited
Loading

Task: On candle trades go to a specific time

Description:

  • Adds Go to modal to the trades Candles section and related logic to handle selectable visibility range on the chart

Preview:

candles-go-to-feat.mov

alexstotsky added 30 commits June 20, 2022 15:04
Add go-to icon
c80de50
Update icons styling
734c082
Optimize icon config, update exports
e51a11c
Add go_to key and description
1f18e5d
Implement go to btn with tooltip
9f9f061
Optimize btn and improve reusability
141b1a3
Update candles header
ededf94
Add candles header styling
f3d0244
Cleanup
092e24d
[WIP] Go to range modal
dcca3d0
Add go to range modal styling
1449b3e
Class name fix
20e301b
Define range dialog types/defaults
f9c88f1
Lint fix
4ee1527
Add range modal container
cb45e76
Update state ui actions and constants
32d95f6
Add GoToRangeDialog to Main
9a7f9bb
Adjust icon size
b54a9bc
Update ui reducers
61a9f85
Improve go to modal icon and title
4ac7a85
Update candles header styling
ff8fab7
Update candles methods
490f8c4
[WIP] Go to range selector
d9cf35e
Add range selector styling
089d8a2
Update candles prop-types
fcd2c52
Update timeframe keys/descriptions
11c91f7
Improve range modal spacing
6e31a32
Update state ui selectors
5b2a5e3
Update range dialog mapped props
f2f377c
Add range selector to modal, update confirm btn
0fde362
alexstotsky added 21 commits June 20, 2022 15:05
@alexstotsky alexstotsky force-pushed the candles-select-time branch from d7eea4e to d6ca22a Compare June 20, 2022 12:05
@alexstotsky alexstotsky changed the title [WIP] (feature) Go to a specific date on the candles chart (feature) Go to a specific date on the candles chart Jun 20, 2022
@alexstotsky alexstotsky marked this pull request as ready for review June 20, 2022 12:06
ezewer
ezewer approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@prdn prdn merged commit a48df90 into bitfinexcom:master Jun 24, 2022
@alexstotsky alexstotsky deleted the candles-select-time branch June 24, 2022 09:11
This was referenced Jul 8, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezewer ezewer ezewer approved these changes

@elvis-poggi elvis-poggi elvis-poggi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexstotsky @ezewer @elvis-poggi @prdn