Add ability to overwrite rpc timeout #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b695071 to
768dc0e
Compare
768dc0e to
6274875
Compare
This was referenced Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to overwrite
RPCtimeoutThe idea is to have
httpRpcTimeoutandwsRpcTimeoutoptions that can be overwritten in the electron environment for complicated reports which can have a lot of internal calls to theBFX APIthat can take significant timeBy default:
httpRpcTimeoutwill be used hardcoded90stimeout, as earlierwsRpcTimeoutwill be used hardcoded90stimeout, earlier it was10sAlso adds a fix to provide
actionfield for error response by WS