这是indexloc提供的服务，不要输入任何密码
Skip to content

Add apple signing and notarization workflow #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jan 31, 2024
Merged

Add apple signing and notarization workflow #299

merged 19 commits into from
Jan 31, 2024

Conversation

@ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Jan 16, 2024 •
edited
Loading

This PR adds Apple signing and notarization workflow

Required set GitHub secrets:

APPLE_TEAM_ID: ${{ secrets.BFX_APPLE_TEAM_ID }}
APPLE_ID: ${{ secrets.BFX_APPLE_ID_USERNAME }}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.BFX_APPLE_ID_REPORT_PASSWORD }}
CSC_LINK: ${{ secrets.BFX_APPLE_BUILD_CERTIFICATE_B64 }}
CSC_KEY_PASSWORD: ${{ secrets.BFX_APPLE_BUILD_CERTIFICATE_PASSWORD }}

ezewer and others added 19 commits January 11, 2024 19:01
@ezewer
Merge pull request bitfinexcom#298 from bitfinexcom/staging
2ef39b2 
Release version 4.17.0
@ZIMkaRU
Provide apple credential env vars to mac-builder workflow
a5b685e
@ZIMkaRU
Add apple credential env vars to .env file
83bda1e
@ZIMkaRU
Add required apple app sandbox entitlements
6699674
@ZIMkaRU
Add mac dmg target release
6a5c610
@ZIMkaRU
Set mac type opt as distribution
2febf24
@ZIMkaRU
Enable dark mode support for mac
e4a1567
@ZIMkaRU
Hardcode 11 minimum system version for mac
b323193
@ZIMkaRU
Add ability to set teamId from env var
5931d6e
@ZIMkaRU
Add ability to turn off notarizing
fa19678
@ZIMkaRU
Imprive parsing env val to bool
e735d35
@ZIMkaRU
Turn off apple app sandbox for standard darwin build
c9fe9c7 
https://www.electronjs.org/docs/latest/tutorial/mac-app-store-submission-guide#enable-apples-app-sandbox
@ZIMkaRU
Add ability to build zip release with native mac tool
abb0eb6
@ZIMkaRU
Fix arch opt for mac build
c3b39bc
@ZIMkaRU
Increase mac-builder timeout
c20694c
@ZIMkaRU
Skip backup file creation on mac when using sed cli
cad4d38 
If a zero-length extension is given after -i, no backup will be saved
https://man.openbsd.org/sed
@ZIMkaRU
Fix mac release size to exclude cache dir
eab5331
@ZIMkaRU
Replace macos sed with gnu sed
e6324f3
@ZIMkaRU
Cleanup electron-builder config
8571b61
@ZIMkaRU ZIMkaRU marked this pull request as ready for review January 16, 2024 06:26
ezewer
ezewer approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, would wait on secrets before merging.

@ZIMkaRU ZIMkaRU mentioned this pull request Jan 31, 2024
Merged
ezewer
ezewer approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ezewer ezewer merged commit f3f8b10 into bitfinexcom:staging Jan 31, 2024
@ZIMkaRU ZIMkaRU mentioned this pull request Jan 31, 2024
Merged
@ZIMkaRU ZIMkaRU deleted the feature/add-apple-signing-and-notarization-workflow branch March 13, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezewer ezewer ezewer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZIMkaRU @ezewer