这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Nov 10, 2023

This PR adds automated testing for electron app binaries


To be sure that the release build of the Electron app has been successful adds ability to auto-validate that the application works fine on all OSs (Linux, Mac, Win):


The flow:

  • build release on GitHub Actions
  • use unpacked builds for E2E tests
  • launch E2E test on Linux, Mac, Win OSs independently
  • provide E2E test reports for every OS launch

Basic changes:

  • adds simple E2E using WebdriverIO for verifying binaries
  • prevents removal app unpacked folder for E2E test runner
  • reworks electron-builder config to be able to launch E2E tests
  • adds E2E test runner to GitHub actions
  • add E2E test report workflow
  • skips redundant files in build
  • bumps Electron up to 27.0.4
  • bump electron-builder up to 24.8.1 to have executable name fix
  • bumps actions/checkout up to v4
  • adds cross-env for dev/test scripts
  • adds local GitHub Action to turn uninterrupted E2E testing on macOS Mac image starts with open system dialogs actions/runner-images#978 (comment)
  • uses macos-12 in GitHub Actions
  • disables enforce macos app location for E2E test runner

Examples of E2E test runners and reports:

Screenshot from 2023-11-10 13-21-17

Screenshot from 2023-11-10 13-21-57

Screenshot from 2023-11-10 13-22-17

Screenshot from 2023-11-08 12-54-28

Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small request, rest looks good!

@ZIMkaRU ZIMkaRU force-pushed the feature/add-automated-testing-for-electron-app-binaries branch from b426015 to 2af7deb Compare December 14, 2023 10:41
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ezewer ezewer merged commit f7bef63 into bitfinexcom:staging Jan 2, 2024
This was referenced Jan 11, 2024
@ZIMkaRU ZIMkaRU deleted the feature/add-automated-testing-for-electron-app-binaries branch March 13, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants