-
Notifications
You must be signed in to change notification settings - Fork 15
Add automated testing for electron app binaries #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ezewer
merged 48 commits into
bitfinexcom:staging
from
ZIMkaRU:feature/add-automated-testing-for-electron-app-binaries
Jan 2, 2024
Merged
Add automated testing for electron app binaries #276
ezewer
merged 48 commits into
bitfinexcom:staging
from
ZIMkaRU:feature/add-automated-testing-for-electron-app-binaries
Jan 2, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezewer
requested changes
Nov 13, 2023
Contributor
ezewer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small request, rest looks good!
Release version 4.16.0
b426015 to
2af7deb
Compare
ezewer
approved these changes
Jan 2, 2024
Contributor
ezewer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
This was referenced Jan 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds automated testing for electron app binaries
To be sure that the release build of the Electron app has been successful adds ability to auto-validate that the application works fine on all OSs (Linux, Mac, Win):
The flow:
Basic changes:
WebdriverIOfor verifying binarieselectron-builderconfig to be able to launch E2E testsElectronup to27.0.4electron-builderup to24.8.1to have executable name fixactions/checkoutup to v4cross-envfordev/testscriptslocalGitHub Action to turn uninterrupted E2E testing on macOS Mac image starts with open system dialogs actions/runner-images#978 (comment)macos-12in GitHub ActionsExamples of E2E test runners and reports: