Add ability to override path to db #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2020
ezewer
approved these changes
Jan 9, 2020
ezewer
left a comment
There was a problem hiding this comment.
Looks good to me! a good remark is that this is required as to work on electrons mac distributions as db cant be located in root/db/etc
robertkowalski
suggested changes
Jan 10, 2020
| label, | ||
| persist | ||
| } = this.opts | ||
| const baseName = `${this.name}_${this.opts.name}_${label}.db.json` |
Contributor
There was a problem hiding this comment.
same issue here, for undefined options.
also, tests are missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an ability to override path to db
This PR is required for this PR bfx-report#160