这是indexloc提供的服务，不要输入任何密码
Skip to content

[8.3.1] Remove the "overwrote runfiles" warning #26374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 24, 2025
Merged

[8.3.1] Remove the "overwrote runfiles" warning #26374

merged 4 commits into from
Jun 24, 2025

Conversation

Wyverald
Copy link
Member

Original commits:

@Wyverald Wyverald requested a review from a team as a code owner June 24, 2025 21:19
@Wyverald Wyverald added this to the 8.3.1 release blockers milestone Jun 24, 2025
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Jun 24, 2025
lberki added 2 commits June 24, 2025 17:51
@lberki @Wyverald
Make Bazel not crash if a runfiles tree is in a runfiles tree.
11eec7c 
There was a test for this, but it didn't check for the exit code, only the error message and the message printed on the crash coincidentally contained the expected message.

My best understanding is that this was broken in unknown commit. The root cause of why that change was imperfect is probably the odd behavior that if one posts an error to the event handler in ActionExecutionContext, the action doesn't automatically fail.

RELNOTES: None.
PiperOrigin-RevId: 697564109
Change-Id: I0847bd7f090af44ffd37880b4957755bca511ad1
@lberki @Wyverald
Remove the "overwrote runfile" warning.
7f61296 
At HEAD, this is reported on the console as an error but doesn't actually cause a build error and this has been the case for a long time. This means that this particular cat is out of the bag and we can't prohibit this behavior anymore and therefore it's better to not emit spam.

RELNOTES: None.
PiperOrigin-RevId: 720983277
Change-Id: I2f62247b7bb7a81e30281ab578a8b93f17cef476
@iancha1992 iancha1992 enabled auto-merge (squash) June 24, 2025 21:59
@iancha1992 iancha1992 merged commit 57d25be into release-8.3.1 Jun 24, 2025
49 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jun 24, 2025
@Wyverald Wyverald deleted the wyv-831-silence branch June 25, 2025 00:25
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Jun 25, 2025
@Wyverald @lberki @iancha1992
[8.3.1] Remove the "overwrote runfiles" warning (bazelbuild#26374)
0964c1f 
Original commits:
* e8b2790
* 1e9c127

---------

Co-authored-by: Googler <lberki@google.com>
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Jun 25, 2025
@Wyverald @lberki @iancha1992
[8.3.1] Remove the "overwrote runfiles" warning (bazelbuild#26374)
bdda9f5 
Original commits:
* e8b2790
* 1e9c127

---------

Co-authored-by: Googler <lberki@google.com>
github-merge-queue bot pushed a commit that referenced this pull request Jun 26, 2025
@iancha1992 @Wyverald @lberki
[8.4.0] Remove the "overwrote runfiles" warning (#26374) (#26382)
5988254 
Original commits:
* e8b2790
* 1e9c127

---------

Commit
57d25be

Co-authored-by: Xùdōng Yáng <wyverald@gmail.com>
Co-authored-by: Googler <lberki@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iancha1992 iancha1992 iancha1992 approved these changes

Assignees
No one assigned
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
8.3.1 release blockers
Development

Successfully merging this pull request may close these issues.
3 participants
@Wyverald @iancha1992 @lberki