Fix generate_linkmap for cc_binary #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are 2 separate codepaths for linkmaps, `--objc_generate_linkmap` enables the `linkmap_exec_path` variable, and just passing `--features=generate_linkmap` enables linkmap outputs, without any other variables.
576f7bb to
3594e2c
Compare
aaronsky
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 separate codepaths for linkmaps,
--objc_generate_linkmapenables the
linkmap_exec_pathvariable, and just passing--features=generate_linkmapenables linkmap outputs, without any othervariables.