这是indexloc提供的服务,不要输入任何密码
Skip to content

Drop support for bazel 6 #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

aaronsky
Copy link
Contributor

@aaronsky aaronsky commented Dec 6, 2024

Matching what was done in bazelbuild/rules_apple#2610

@aaronsky aaronsky marked this pull request as ready for review December 6, 2024 22:32
@keith
Copy link
Member

keith commented Dec 6, 2024

change looks good, but def an interesting policy question since this repo is potentially used for non rules_apple projects

@brentleyjones
Copy link
Collaborator

In rules_apple we needed to do this to support the new linking stuff. I don't think we need to do this yet. We should feel fine with dropping LTS-2 if we need to, but I don't think we gain much by doing it in apple_support right now?

@aaronsky aaronsky closed this Dec 9, 2024
@keith
Copy link
Member

keith commented Mar 28, 2025

@aaronsky 6.x has gotten more annoying to support, want to reopen this so we can move forward with it?

@aaronsky aaronsky reopened this Mar 28, 2025
@aaronsky aaronsky force-pushed the aaronsky/drop-bazel-6-support branch from 3b2bf08 to 83012ee Compare March 28, 2025 21:19
@aaronsky
Copy link
Contributor Author

@keith with this test failure, i know your libtool change slightly altered the hashing representation of objects – could that be related?

@keith
Copy link
Member

keith commented Mar 28, 2025

i don't see what in this PR would change that yet, but it's fine to update the tests w/ the new values

@aaronsky aaronsky merged commit 5f0b1f4 into bazelbuild:master Mar 28, 2025
10 checks passed
@luispadron
Copy link
Contributor

Nice this makes the other cherry picks easier to land, I'll get that Xcode rules fork PR updated in a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants