这是indexloc提供的服务,不要输入任何密码
Skip to content

Fix Buildifier version #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

fweikert
Copy link
Member

@fweikert fweikert commented Mar 7, 2019

"buildifier: true" has been deprecated by bazelbuild/continuous-integration#542

"buildifier: true" has been deprecated by bazelbuild/continuous-integration#542
sergiocampama pushed a commit that referenced this pull request Mar 7, 2019
"buildifier: true" has been deprecated by bazelbuild/continuous-integration#542

Closes #18.

RELNOTES: None.
PiperOrigin-RevId: 237246313
swiple-rules-gardener pushed a commit that referenced this pull request Apr 4, 2019
Change this pattern
    if foo [not] in native.existing_rules():
to
    if [not] native.existing_rule(foo):
for efficiency.

PiperOrigin-RevId: 241510848
swiple-rules-gardener pushed a commit that referenced this pull request Apr 4, 2019
Change this pattern
    if foo [not] in native.existing_rules():
to
    if [not] native.existing_rule(foo):
for efficiency. This is mainly for herb right now, but in general the pattern should be to use the most direct existence check.

PiperOrigin-RevId: 241510848
swiple-rules-gardener pushed a commit that referenced this pull request Apr 4, 2019
Change this pattern
    if foo [not] in native.existing_rules():
to
    if [not] native.existing_rule(foo):
for efficiency.

PiperOrigin-RevId: 241510848
swiple-rules-gardener pushed a commit that referenced this pull request Apr 4, 2019
Change this pattern
    if foo [not] in native.existing_rules():
to
    if [not] native.existing_rule(foo):
for efficiency.

PiperOrigin-RevId: 241954724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants