-
Notifications
You must be signed in to change notification settings - Fork 11
Support modern test262.zip files #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| #!/usr/bin/env python3 | ||
| from http.server import HTTPServer, SimpleHTTPRequestHandler | ||
| import sys | ||
|
|
||
| class CustomRequestHandler(SimpleHTTPRequestHandler): | ||
| def end_headers(self): | ||
| self.send_header('Cross-Origin-Embedder-Policy', 'require-corp') | ||
| self.send_header('Cross-Origin-Opener-Policy', 'same-origin') | ||
| return super(CustomRequestHandler, self).end_headers() | ||
|
|
||
| host = sys.argv[1] if len(sys.argv) > 2 else '0.0.0.0' | ||
| port = int(sys.argv[len(sys.argv)-1]) if len(sys.argv) > 1 else 8000 | ||
|
|
||
| print("Listening on {}:{}".format(host, port)) | ||
| print("Connect to http://localhost:{}/ for cross-origin isolation".format(port)) | ||
| httpd = HTTPServer((host, port), CustomRequestHandler) | ||
| httpd.serve_forever() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to commit this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. Sorry i didn't explain: Its a bit of a pain to test SAB without a file like this, so if you want to start a cross origin isolated version of this repo you can run python3 cross-origin-http.py and it will do it for you. I can add a readme? Forgot to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(was the original reason i forked and started mucking about)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A sentence or two in the readme would be great, yeah.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember I'll try to add my standard fix for this, which is a service worker to inject the necessary headers (so that it can still be done on Github Pages instead of needing the local server). But no promises on timeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh thats a nice way to do it. Well -- i can add the readme change for now and when you've got time for something more elegant you can just remove this file and the line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, thanks!