这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@codehag
Copy link
Contributor

@codehag codehag commented Mar 11, 2025

I noticed when running this that recent test262 zip files break. The recent addition of the "sm" directory is the cause of the breakage: https://github.com/tc39/test262/tree/main/harness/sm

This should be fixed at some point, but for now we can just ignore paths that result in no valid tests.

@@ -0,0 +1,17 @@
#!/usr/bin/env python3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to commit this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. Sorry i didn't explain: Its a bit of a pain to test SAB without a file like this, so if you want to start a cross origin isolated version of this repo you can run python3 cross-origin-http.py and it will do it for you. I can add a readme? Forgot to do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(was the original reason i forked and started mucking about)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A sentence or two in the readme would be great, yeah.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember I'll try to add my standard fix for this, which is a service worker to inject the necessary headers (so that it can still be done on Github Pages instead of needing the local server). But no promises on timeline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh thats a nice way to do it. Well -- i can add the readme change for now and when you've got time for something more elegant you can just remove this file and the line?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, thanks!

@bakkot bakkot merged commit 5a0b074 into bakkot:master Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants