feat: use libraries mocktail and mockito #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amondnet
reviewed
May 26, 2021
Comment on lines
+5
to
+8
| export 'src/grpc/mockito/fake_client_call.dart'; | ||
| export 'src/grpc/mockito/fake_response_future.dart'; | ||
| export 'src/grpc/mocktail/mock_client_call.dart'; | ||
| export 'src/grpc/mocktail/mock_response_future.dart'; |
Contributor
There was a problem hiding this comment.
별도의 file 로 나누어서 export 해야 하지 않을까요?
Contributor
Author
There was a problem hiding this comment.
그게 더 확실할 것 같습니다.
근데 어제도 말씀드린바와 같이 mocktail이 injected 되지 않은 패키지에서도
mock_response_future이 잘 동작하던데 둘 중 하나만 남겨놔도 상관없는걸까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.