chore: disable flag on unsafe/test RPCs #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a configuration option to disable unsafe RPC endpoints (specifically UnsafeSignEOTS) for production environments. The UnsafeSignEOTS endpoint bypasses slashing protection and should only be used for testing purposes.
- Added a
DisableUnsafeEndpointsboolean configuration field that defaults tofalsefor backward compatibility - Modified the
UnsafeSignEOTSRPC handler to check this configuration flag and return aPermissionDeniederror when disabled - Updated the
rpcServerstruct to include the configuration and modified its constructor to accept the config parameter
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eotsmanager/config/config.go | Added DisableUnsafeEndpoints field to the Config struct with appropriate documentation and default value |
| eotsmanager/service/rpcserver.go | Added config dependency to rpcServer struct and implemented guard check in UnsafeSignEOTS method |
| eotsmanager/service/server.go | Updated newRPCServer call to pass the config parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| cfg *config.Config | ||
| } | ||
|
|
||
| // newRPCServer creates a new RPC sever from the set of input dependencies. |
There was a problem hiding this comment.
Corrected spelling of 'sever' to 'server'.
Suggested change
| // newRPCServer creates a new RPC sever from the set of input dependencies. | |
| // newRPCServer creates a new RPC server from the set of input dependencies. |
mergify bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
(cherry picked from commit 67379d4)
Lazar955
added a commit
that referenced
this pull request
Nov 7, 2025
<hr>This is an automatic backport of pull request #736 done by [Mergify](https://mergify.com). Co-authored-by: Lazar <12626340+Lazar955@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.