chore: rm unused cfg val #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unused NumPubRandMax configuration field from the finality provider codebase to clean up dead code.
- Removed
NumPubRandMaxfield from theConfigstruct and related default constant - Removed references from test utilities
- Updated CHANGELOG to document the change
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| finality-provider/config/config.go | Removed NumPubRandMax field from Config struct, removed defaultNumPubRandMax constant, and cleaned up related initialization code |
| itest/utils.go | Removed NumPubRandMax assignment from test configuration setup |
| CHANGELOG.md | Added entry for PR #734 documenting removal of unused config value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RafilxTenfen
approved these changes
Nov 6, 2025
mergify bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
(cherry picked from commit 9e3a485)
Lazar955
added a commit
that referenced
this pull request
Nov 7, 2025
<hr>This is an automatic backport of pull request #734 done by [Mergify](https://mergify.com). Co-authored-by: Lazar <12626340+Lazar955@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.