这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@toroviej0x0
Copy link
Contributor

@toroviej0x0 toroviej0x0 commented Nov 5, 2025

# HELP fp_version_info Version information of the finality provider binary
# TYPE fp_version_info gauge
fp_version_info{commit="f75233c",timestamp="2025-11-04T16:43:39Z",version="4.0.0-rc.0-107-gf75233c"} 1

Copilot AI review requested due to automatic review settings November 5, 2025 00:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds version information tracking to the finality provider metrics system. The changes enable Prometheus to expose version details (version number, git commit, and build timestamp) for operational monitoring and debugging purposes.

  • Adds a new versionInfo Prometheus GaugeVec metric to track version information
  • Integrates with the existing version package to extract commit and timestamp details
  • Sets the version metric once at startup within the singleton initialization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@Lazar955 Lazar955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

Comment on lines +46 to +47
* [#732](https://github.com/babylonlabs-io/finality-provider/pull/732)
* feat: add version metric
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [#732](https://github.com/babylonlabs-io/finality-provider/pull/732)
* feat: add version metric
* [#732](https://github.com/babylonlabs-io/finality-provider/pull/732) feat: add version metric

@toroviej0x0 toroviej0x0 merged commit 6c6f990 into main Nov 5, 2025
20 checks passed
@toroviej0x0 toroviej0x0 deleted the feat/add-version-metric branch November 5, 2025 18:03
mergify bot pushed a commit that referenced this pull request Nov 5, 2025
```
# HELP fp_version_info Version information of the finality provider binary
# TYPE fp_version_info gauge
fp_version_info{commit="f75233c",timestamp="2025-11-04T16:43:39Z",version="4.0.0-rc.0-107-gf75233c"} 1
```

(cherry picked from commit 6c6f990)
Copilot AI mentioned this pull request Nov 6, 2025
Lazar955 pushed a commit that referenced this pull request Nov 7, 2025
```
# HELP fp_version_info Version information of the finality provider binary
# TYPE fp_version_info gauge
fp_version_info{commit="f75233c",timestamp="2025-11-04T16:43:39Z",version="4.0.0-rc.0-107-gf75233c"} 1
```<hr>This is an automatic backport of pull request #732 done by
[Mergify](https://mergify.com).

Co-authored-by: Julian <155650345+toroviej0x0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants