chore: adds check for pk from bytes #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation checks for private key bytes before converting them to secp256k1 private keys. The validation ensures that private key bytes are within the valid curve order and are not zero.
- Adds overflow validation to check that private key bytes don't exceed secp256k1 curve order
- Adds zero validation to prevent private keys with zero value
- Includes descriptive comments explaining the validation purpose
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| keyring/keyringcontroller.go | Adds private key validation in CreateChainKey method before btcec.PrivKeyFromBytes call |
| eotsmanager/localmanager.go | Adds identical private key validation in getKeyFromKeyring method before btcec.PrivKeyFromBytes call |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
KonradStaniec
approved these changes
Oct 14, 2025
mergify bot
pushed a commit
that referenced
this pull request
Oct 15, 2025
_V4-CORE-004_ (cherry picked from commit 43239a9)
Lazar955
added a commit
that referenced
this pull request
Oct 15, 2025
_V4-CORE-004_<hr>This is an automatic backport of pull request #725 done by [Mergify](https://mergify.com). Co-authored-by: Lazar <12626340+Lazar955@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V4-CORE-004