chore: recover-rand-proof cosmos #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- extend consumerctrl interface - change commands - extend pub rand interface and impl - impl cosmwasm version
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the recover-rand-proof command functionality for cosmos finality provider daemon (fpd). The command helps recover public randomness proofs from a consumer chain back to the local database after a data loss scenario.
- Refactors the PubRandCommit interface to use getter methods for better abstraction across different chain types
- Implements
QueryPublicRandCommitListmethod across all consumer controllers (Babylon, Cosmos, Rollup) - Updates the recover-proof command to work with the new interface and accept a consumer controller parameter
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| types/pub_rand_commit.go | Adds getter methods to PubRandCommit interface for better abstraction |
| finality-provider/cmd/fpd/daemon/recover_proof.go | Refactors recover proof command to accept consumer controller and use new interface methods |
| clientcontroller/babylon/pubrand.go | Creates separate file for BabylonPubRandCommit struct with interface implementation |
| clientcontroller/babylon/consumer.go | Moves BabylonPubRandCommit to separate file and updates QueryPublicRandCommitList signature |
| clientcontroller/api/interface.go | Adds QueryPublicRandCommitList method to RandomnessCommitter interface |
| bsn/rollup/clientcontroller/pubrand.go | Creates RollupPubRandCommit struct with getter methods |
| bsn/rollup/clientcontroller/consumer.go | Adds stub implementation of QueryPublicRandCommitList |
| bsn/cosmos/clientcontroller/consumer.go | Implements QueryPublicRandCommitList method for cosmos consumer controller |
| bsn/cosmos/e2e/bcd_consumer_e2e_test.go | Adds comprehensive test for recover-proof command functionality |
SebastianElvis
approved these changes
Aug 8, 2025
Lazar955
added a commit
that referenced
this pull request
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
recover-rand-proofcmd for cosmos fpd.Next PR will be for rollup fpd, didn't want this PR to be too big.