chore(rollup): add e2e and unit tests for sparse pub randomness #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit tests for the sparse public randomness functionality in the rollup randomness committer. The tests verify the ShouldCommit function's decision logic across various scenarios including first commits, coverage validation, gap handling, and edge cases.
- Adds 493 lines of test code covering 35+ test scenarios for the
RollupRandomnessCommitter.ShouldCommitfunction - Updates the CHANGELOG.md to document this testing enhancement
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| finality-provider/service/rollup_rand_committer_test.go | New comprehensive test suite for rollup randomness committer covering first commits, coverage scenarios, gap handling, and various edge cases |
| CHANGELOG.md | Adds entry for the new unit tests and reformats existing entries for better readability |
gusin13
commented
Aug 6, 2025
|
|
||
| // QueryFirstPubRandCommit returns the first public randomness commitment | ||
| // It is fetched from the state of a CosmWasm contract OP finality gadget. | ||
| func (cc *RollupBSNController) QueryFirstPubRandCommit(ctx context.Context, fpPk *btcec.PublicKey) (*RollupPubRandCommit, error) { |
🚨 Bugbot Trial ExpiredYour Bugbot trial has expired. Please purchase a license in the Cursor dashboard to continue using Bugbot. |
SebastianElvis
approved these changes
Aug 7, 2025
Member
SebastianElvis
left a comment
There was a problem hiding this comment.
This is super tight unit test 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.