chore: mv helper methods from fpi #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors testing utilities by moving helper methods from the finality provider instance to a dedicated test helper struct. The purpose is to better organize test-related functionality and separate it from production code.
- Creates a new
FinalityProviderTestHelperstruct to encapsulate testing utilities - Moves test helper methods from
FinalityProviderInstanceto the dedicated test helper - Updates all callers to use the new test helper interface
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| finality-provider/service/fp_test_helper.go | New file containing the FinalityProviderTestHelper struct with moved test utility methods |
| finality-provider/service/fp_instance.go | Removes test helper methods and adds factory method for creating test helper instances |
| finality-provider/service/rpcserver.go | Updates to use new test helper interface for finality signature submission |
| finality-provider/cmd/fpd/daemon/commit_pr.go | Updates to use new test helper interface for public randomness commitment |
| itest/babylon/babylon_e2e_test.go | Updates test calls to use new test helper interface |
samricotta
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better housekeeping, remove methods used in test from FPI, less noise