rollup: remove dependency to finality gadget #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the coupling to the finality gadget from the rollup finality provider, cleans up unused code, and tightens visibility on internal methods.
- Removed the
finality-gadgetmodule from dependencies. - Deleted
BabylonFinalityGadgetRpcand its uses in configs and tests. - Stripped out unused imports/consts and made several methods private with
nolintwhere appropriate.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Removed github.com/babylonlabs-io/finality-gadget dependency |
| bsn/rollup-finality-provider/e2e/op_test_manager.go | Deleted unused test config BabylonFinalityGadgetRpc |
| bsn/rollup-finality-provider/config/config.go | Removed BabylonFinalityGadgetRpc field from RollupFPConfig |
| bsn/rollup-finality-provider/clientcontroller/consumer.go | Cleared unused math import/consts, excised obsolete methods, lowercased/exposed internals |
| CHANGELOG.md | Added entry for PR #526 and reordered entries for clarity |
Comments suppressed due to low confidence (2)
CHANGELOG.md:51
- [nitpick] Inconsistent issue reference formatting: some entries use
[515]while others use[#517]. Standardize to include the#for consistency across changelog entries.
* [515](https://github.com/babylonlabs-io/finality-provider/pull/515) chore: abstract randomness committer
bsn/rollup-finality-provider/clientcontroller/consumer.go:98
- Lowercasing
QueryContractConfigtoqueryContractConfigmay break theapi.ConsumerControllerinterface assertion (var _ api.ConsumerController = &RollupBSNController{}) if the interface expects it exported. Ensure the interface definition is updated or keep this method public.
func (cc *RollupBSNController) queryContractConfig(ctx context.Context) (*Config, error) {
3 tasks
Lazar955
approved these changes
Jul 17, 2025
0xAleksaOpacic
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #503
This PR removes the dependency to finality gadget in
rollup-fpd, removes certain unused varaibles/functions, and makes certain functions private.