cli: generalise CLIs and introduce CLIs for rollup FP #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a6b8877 to
05e20e9
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors and generalizes the CLI layer for finality providers and applies the new abstractions to implement a rollup BSN CLI.
- Extract common, keys, incentive, and version subcommands into reusable packages
- Refactor daemon commands into templates and shared utilities
- Add a rollup-specific CLI by wiring the generalized commands
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| version/cmd.go | Introduce AddVersionCommands helper and tidy imports |
| types/txresponse.go | Add PrintRespJSON helper for pretty-printed JSON responses |
| finality-provider/cmd/fpd/main.go | Rewrite root command to use generic Add*Commands calls |
| finality-provider/cmd/fpd/daemon/start.go | Separate template and execution for the start subcommand |
| bsn/rollup-finality-provider/cmd/rollup-fpd/main.go | Bootstraps rollup CLI using the shared command packages |
Comments suppressed due to low confidence (2)
finality-provider/cmd/fpd/main.go:40
- [nitpick] New generic CLI groups are registered here but there are no unit tests verifying that the expected subcommands are present. Consider adding tests for
AddCommonCommandsto ensure all shared commands are wired correctly.
commoncmd.AddCommonCommands(cmd)
bsn/rollup-finality-provider/cmd/rollup-fpd/main.go:40
- [nitpick] The rollup CLI now reuses shared command groups but lacks tests to confirm correct registration. Adding tests around
NewRootCmdfor rollup-fpd would improve confidence.
commoncmd.AddCommonCommands(cmd)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Lazar955
approved these changes
Jul 15, 2025
Member
Lazar955
left a comment
There was a problem hiding this comment.
Overall lgtm, minor comments, let's wait for one more review
bsn/rollup-finality-provider/cmd/rollup-fpd/daemon/create_fp.go
Outdated
Show resolved
Hide resolved
bsn/rollup-finality-provider/cmd/rollup-fpd/daemon/create_fp.go
Outdated
Show resolved
Hide resolved
KonradStaniec
approved these changes
Jul 16, 2025
Contributor
KonradStaniec
left a comment
There was a problem hiding this comment.
nothing blocking from me :) lets just wrap errors when necessary it will help us later with all the problems
bsn/rollup-finality-provider/cmd/rollup-fpd/daemon/create_fp.go
Outdated
Show resolved
Hide resolved
bsn/rollup-finality-provider/cmd/rollup-fpd/daemon/create_fp.go
Outdated
Show resolved
Hide resolved
Member
Author
|
will wait for @0xAleksaOpacic to test out the UPDATE: working properly (except for known issues in fpd) now 🎉 |
This was referenced Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #507
This PR generalises the implementation of existing CLIs for the finality provider, and leverage the generalised utilities to implement the CLIs for rollup BSNs. In particular, this PR
finality-provider/cmd/fpd/common/common_cmd.go), shared among any type of FPsfinality-provider/cmd/fpd/common/incentive_cmd.go), shared among any type of FPsfinality-provider/cmd/fpd/common/keys_cmd.go), shared among any type of FPsversion/), shared among any type of FPsfinality-provider/cmd/fpd/daemon), that are specific to each type of FPsfinality-provider/cmd/fpd/daemonsuch that most of the code is reusable for other types of FPsFinalityProviderApp. The refactoring allows having different logics for this part whereas the other parts remain reusable.finality-provider/cmd/fpd/daemonto construct the daemon cmds for rollup FPs.This is a major refactoring to simplify the development of the BSN finality providers.
Some future work in subsequent PRs: