chore: bump babylon to v3 #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR bumps rollup finality contract and fixes rollup e2e
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the Babylon SDK to v3 and updates import paths and related logic across the codebase.
- Updated all Babylon module imports (types, client, x modules) to use
github.com/babylonlabs-io/babylon/v3. - Adjusted proof‐of‐possession and randomness commit flows to include chainID-based signing contexts.
- Bumped Go toolchain and dependency versions in
go.modandtools/go.mod.
Reviewed Changes
Copilot reviewed 66 out of 70 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| types/txresponse.go | Updated import path to babylon/v3/client/babylonclient. |
| keyring/keyringcontroller.go | Changed CreatePop signature to accept chainID and use FpPopContextV0. |
| clientcontroller/api/interface.go | Added GetFpPopContextV0, GetFpRandCommitContext, and GetFpFinVoteContext. |
| tools/go.mod | Bumped Go version and updated demo SDK, indirect dependencies to v3-compatible. |
| ... | All other files similarly updated import paths to babylon/v3 modules. |
Comments suppressed due to low confidence (4)
keyring/keyringcontroller.go:121
- The doc comment above
CreatePopshould be updated to mention the newchainIDparameter and describe how the signing context is derived.
func (kc *ChainKeyringController) CreatePop(chainID string, fpAddr sdk.AccAddress, btcPrivKey *btcec.PrivateKey) (*bstypes.ProofOfPossessionBTC, error) {
finality-provider/service/app.go:494
- Update or add a doc comment for
CreatePopto reflect its new signature (removal ofsignCtxparameter) and explain how the context is now obtained viaapp.cc.GetFpPopContextV0().
func (app *FinalityProviderApp) CreatePop(fpAddress sdk.AccAddress, fpPk *bbntypes.BIP340PubKey) (*bstypes.ProofOfPossessionBTC, error) {
clientcontroller/opstackl2/msg.go:44
- [nitpick] Add a doc comment explaining the purpose of the
Configstruct and its fields (BsnID,MinPubRand).
type Config struct {
clientcontroller/opstackl2/msg.go:45
- [nitpick] Consider renaming the field to
BSNIDto match the uppercase acronym style, or document the chosen casing convention.
BsnID string `json:"bsn_id"`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.