chore: unlock cmd hmac and password from input #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Lazar955
commented
Jun 6, 2025
- Provide the user with the option to use HMAC.
- Use a more secure way to read the password for keyring unlock.
vitsalis
reviewed
Jun 6, 2025
gitferry
reviewed
Jun 6, 2025
Member
|
Maybe not for this pr, but I suggest we update the operation doc to add the instructions of using the |
vitsalis
approved these changes
Jun 6, 2025
Member
vitsalis
left a comment
There was a problem hiding this comment.
Small comment. Let's also update the docs?
gitferry
approved these changes
Jun 6, 2025
| f.String(eotsPkFlag, "", "EOTS public key of the finality-provider") | ||
| f.String(passphraseFlag, "", "The keyring passphrase") | ||
| f.String(rpcClientFlag, "", "The RPC address of a running eotsd") | ||
| f.String(sdkflags.FlagHome, "", "The path to the eotsd home directory") |
Member
There was a problem hiding this comment.
Do we want to set the default eotsd home here?
Member
Author
There was a problem hiding this comment.
Leaving it empty intentionally
Lazar955
added a commit
that referenced
this pull request
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.