chore: rm default value for app hash flag #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
approved these changes
Mar 29, 2025
Comment on lines
+409
to
+411
| if len(appHashHex) == 0 { | ||
| return fmt.Errorf("app hash is required") | ||
| } |
Member
There was a problem hiding this comment.
Maybe we can also check the app hash hex should be in correct format?
Member
Author
There was a problem hiding this comment.
Added the len check after we decode it into bytes 76293db. Not sure what else we can validate?
| } | ||
| cmd.Flags().String(fpdDaemonAddressFlag, defaultFpdDaemonAddress, "The RPC server address of fpd") | ||
| cmd.Flags().String(appHashFlag, defaultAppHashStr, "The last commit hash of the chain block") | ||
| cmd.Flags().String(appHashFlag, "", "The last commit hash of the chain block") |
Member
There was a problem hiding this comment.
Can we make this flag required?
Lazar955
added a commit
that referenced
this pull request
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #405