fix: Add expected errors to when sending finality signatures #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
approved these changes
Mar 11, 2025
Member
gitferry
left a comment
There was a problem hiding this comment.
Lgtm! Can we add a testcase for it (seems we also missed tests for other expected errors 😅)?
…te' into Vvaradinov/adapt-err-finality-vote
Member
|
@Vvaradinov Please backport it to |
Contributor
Author
|
@gitferry there are multiple files and folders missing. Should I backport all of the clientcontroller integration with cosmwasm / opstack / babylon ? |
Member
|
@Vvaradinov Nope. I understand there are some structure difference. Please keep it as it is |
Vvaradinov
added a commit
that referenced
this pull request
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #290