feat: HMAC authentication system #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonradStaniec
approved these changes
Mar 10, 2025
Contributor
KonradStaniec
left a comment
There was a problem hiding this comment.
Currently it also works without providing an HMAC key bypassing the security measure. At what point do we error and make this mandatory?
I would say on main net. Although this would be weird, as we would need to release new version with errors 🤔
When I was thinking about it, I though we should always have option to disable it, but have:
- default as enabled
- docs suggesting that it should be left enabled
Then is users disables it, it it on them. Wdyt ?
In general pr looks good to me 👍
Contributor
Author
|
Will do the secrets integration with cloud providers in a follow up PRs. |
gitferry
approved these changes
Mar 11, 2025
Member
gitferry
left a comment
There was a problem hiding this comment.
Great work! Some minor comments:
Vvaradinov
added a commit
that referenced
this pull request
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following is an implementation of the proposed HMAC authentication system from https://github.com/babylonlabs-io/pm/pull/261. A couple of questions I still have on my mind are: