-
Notifications
You must be signed in to change notification settings - Fork 29
chore: fix cmt block fetching #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes Comet block fetching by replacing bulk blockchain info queries with individual block fetching to avoid BlockchainInfo bugs. The implementation adds retry logic with exponential backoff and proper error handling for more reliable block data retrieval.
Key changes:
- Replaces
BlockchainInfoAPI with individualBlockqueries to avoid known issues - Adds retry mechanism with configurable attempts and delays for improved reliability
- Updates function signature to accept limit parameter and use int64 for height consistency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| bsn/cosmos/clientcontroller/consumer.go | Refactors block fetching logic with retry mechanism and individual block queries |
| CHANGELOG.md | Documents the block fetching fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
GAtom22
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @Lazar955!! 🚀
RafilxTenfen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 1a0f819) # Conflicts: # CHANGELOG.md # bsn/cosmos/clientcontroller/consumer.go
<hr>This is an automatic backport of pull request #689 done by [Mergify](https://mergify.com). --------- Co-authored-by: Lazar <12626340+Lazar955@users.noreply.github.com> Co-authored-by: Lazar <lukic.lazar@yahoo.com>
No description provided.