chore: add missing highest voted height #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the previously missing QueryFinalityProviderHighestVotedHeight method for the CosmwasmConsumerController. The implementation replaces a TODO placeholder with actual functionality that queries a smart contract to retrieve the highest voted height for a finality provider.
Key changes:
- Implementation of the
QueryFinalityProviderHighestVotedHeightmethod with smart contract querying - Addition of changelog entry documenting this enhancement
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| bsn/cosmos/clientcontroller/consumer.go | Implements the missing QueryFinalityProviderHighestVotedHeight method with smart contract interaction |
| CHANGELOG.md | Documents the addition of the highest voted height feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
samricotta
approved these changes
Sep 4, 2025
mergify bot
pushed a commit
that referenced
this pull request
Sep 4, 2025
(cherry picked from commit 23ddc19)
Lazar955
added a commit
that referenced
this pull request
Sep 4, 2025
<hr>This is an automatic backport of pull request #685 done by [Mergify](https://mergify.com). Co-authored-by: Lazar <12626340+Lazar955@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.