chore: unify proof building #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR unifies proof building by removing duplicate methods and introducing a variadic options pattern. The main goal is to eliminate code duplication between regular proof building and interval-based proof building by consolidating them into a single flexible API.
- Replaces duplicate
buildKeysandbuildKeysWithIntervalfunctions with a single configurablebuildKeysfunction - Removes the
AddPubRandProofListWithIntervalmethod and consolidates functionality intoAddPubRandProofListusing options - Introduces a functional options pattern with
KeyBuildOptionandWithIntervalfor configurable behavior
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| finality-provider/store/pub_rand.go | Consolidates key building functions and adds options pattern, removes duplicate method |
| finality-provider/service/rand_committer.go | Updates call to use new unified API with interval option |
| finality-provider/service/pub_rand_store_adapter.go | Removes duplicate adapter method and updates existing method to support options |
| bsn/rollup/cmd/rollup-fpd/daemon/recover_proof.go | Updates call to use new unified API with interval option |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
KonradStaniec
approved these changes
Aug 18, 2025
Lazar955
added a commit
that referenced
this pull request
Aug 20, 2025
Remove duplicate methods, use variadic options. Closes #635
Lazar955
added a commit
that referenced
this pull request
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicate methods, use variadic options.
Closes #635