fix: edit finality provider commission-rate
#296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commission-ratecommission-rate
Lazar955
reviewed
Jan 23, 2025
Comment on lines
137
to
145
| currentProvider, err := c.QueryFinalityProviderInfo(ctx, fpPk) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get current provider info: %w", err) | ||
| } | ||
|
|
||
| if rate == "" { | ||
| rate = currentProvider.FinalityProvider.Commission | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
rather, let's first check if rate == "" and do the c.QueryFinalityProviderInfo inside the if statement
gitferry
approved these changes
Jan 24, 2025
Member
gitferry
left a comment
There was a problem hiding this comment.
I'm OK with the current fix. But ideally we should fix it on Babylon side -- follow Cosmos SDK's convension where empty commission rate is accepted. However, I was worried that this would cause breaking change to state as this changes how some txs are handled. Maybe we can leave that to v2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #282
Previously commission rate was required although it should be optional. This fix fetches the already set commission rate otherwise will submit the new one if it is specified by the operator.