chore: Improve fpd start #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazar955
approved these changes
Jan 22, 2025
|
|
||
| printRespJSON(res) | ||
|
|
||
| fmt.Println("You finality provider is successfully created. Please restart your fpd.") |
samricotta
approved these changes
Jan 23, 2025
Contributor
samricotta
left a comment
There was a problem hiding this comment.
Awesome, happy to have this change for testing purposes too
Member
|
Should we also update the docs to specify the rules for the |
5f47e20 to
f702472
Compare
26aa279 to
325dcfc
Compare
gitferry
added a commit
that referenced
this pull request
Jan 27, 2025
Closes #289. With this pr, the `fpd start` flow becomes the follows: - If --eots-pk is specified, start the specified fp instance. Otherwise, - if no fp records found from db, start the daemon and show logs asking for registration - if there's one fp record found from db, start the daemon with the fp - if there are multiple fp record found from db, fail the cmd execution asking for set of --eots-pk
gitferry
added a commit
that referenced
this pull request
Jan 27, 2025
Closes #289. With this pr, the `fpd start` flow becomes the follows: - If --eots-pk is specified, start the specified fp instance. Otherwise, - if no fp records found from db, start the daemon and show logs asking for registration - if there's one fp record found from db, start the daemon with the fp - if there are multiple fp record found from db, fail the cmd execution asking for set of --eots-pk
gitferry
added a commit
that referenced
this pull request
Jan 27, 2025
Closes #289. With this pr, the `fpd start` flow becomes the follows: - If --eots-pk is specified, start the specified fp instance. Otherwise, - if no fp records found from db, start the daemon and show logs asking for registration - if there's one fp record found from db, start the daemon with the fp - if there are multiple fp record found from db, fail the cmd execution asking for set of --eots-pk
gitferry
added a commit
that referenced
this pull request
Jan 27, 2025
Closes #289. With this pr, the `fpd start` flow becomes the follows: - If --eots-pk is specified, start the specified fp instance. Otherwise, - if no fp records found from db, start the daemon and show logs asking for registration - if there's one fp record found from db, start the daemon with the fp - if there are multiple fp record found from db, fail the cmd execution asking for set of --eots-pk
gitferry
added a commit
that referenced
this pull request
Jan 27, 2025
Closes #289. With this pr, the `fpd start` flow becomes the follows: - If --eots-pk is specified, start the specified fp instance. Otherwise, - if no fp records found from db, start the daemon and show logs asking for registration - if there's one fp record found from db, start the daemon with the fp - if there are multiple fp record found from db, fail the cmd execution asking for set of --eots-pk
gitferry
added a commit
that referenced
this pull request
Jan 27, 2025
Closes #289. With this pr, the `fpd start` flow becomes the follows: - If --eots-pk is specified, start the specified fp instance. Otherwise, - if no fp records found from db, start the daemon and show logs asking for registration - if there's one fp record found from db, start the daemon with the fp - if there are multiple fp record found from db, fail the cmd execution asking for set of --eots-pk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #289. With this pr, the
fpd startflow becomes the follows: