feat: export pop command #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
reviewed
Jan 6, 2025
Member
gitferry
left a comment
There was a problem hiding this comment.
One major concern I have is that we should support user to run this command without db which stores the pk and keyname mapping. In this case, the user should be able to sign pop by keyname
Contributor
Author
he can use either the key name or eots-pk |
gitferry
approved these changes
Jan 6, 2025
…ture instead of the PoP
…to rafilx/export-pop
vitsalis
reviewed
Jan 6, 2025
Lazar955
reviewed
Jan 6, 2025
.golangci.yml
Outdated
| - nlreturn | ||
| - noctx | ||
| - nonamedreturns | ||
| # - nonamedreturns named returns are good |
KonradStaniec
approved these changes
Jan 7, 2025
RafilxTenfen
added a commit
that referenced
this pull request
Jan 7, 2025
RafilxTenfen
added a commit
that referenced
this pull request
Jan 8, 2025
#262 New release v0.4.1 after this is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.