feat: rm interceptors and use context #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
approved these changes
Dec 24, 2024
eotsmanager/service/server.go
Outdated
Comment on lines
99
to
101
| // Wait for shutdown signal from either a graceful server stop or from | ||
| // the interrupt handler. | ||
| <-s.interceptor.ShutdownChannel() | ||
| // <-s.interceptor.ShutdownChannel() |
Comment on lines
97
to
100
| // the interrupt handler. | ||
| <-s.interceptor.ShutdownChannel() | ||
| // <-s.interceptor.ShutdownChannel() | ||
| <-ctx.Done() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the usage of
signal.Interceptorand uses Go's idiomaticcontextto handle cancellations. This enables us to run e2e tests in parallel (almost 4x faster).Time in GH action
9m 58svs3m 24sCloses #219