这是indexloc提供的服务,不要输入任何密码
Skip to content

Remove Dnote (Unmaintained since July 2024) #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2025

Conversation

Ki-er
Copy link
Collaborator

@Ki-er Ki-er commented Jul 5, 2025

As part of #1
Removes Dnote

@Ki-er Ki-er added curation Removal of abandoned projects, dead links reviewers wanted Awaiting reviews labels Jul 5, 2025
@Rabenherz112
Copy link
Collaborator

without any external dependencies

https://github.com/dnote/dnote/blob/master/go.mod
The project actually pulls in quite a few external modules.

trivy repo https://github.com/dnote/dnote --scanners vuln
# go.mod (gomod)
# Total: 6 (UNKNOWN: 0, LOW: 0, MEDIUM: 3, HIGH: 2, CRITICAL: 1)

But none of them appear to be exploitable or relevant in this context.

@nodiscc
Copy link
Member

nodiscc commented Jul 7, 2025

I don't think we should exclude it from the checks.
If it has external dependencies they should be kept somewhat up-to-date (or at least not be affected by a CRITICAL vulnerability, even if it's not exploitable).
Also the list already contains a few similar alternatives. I think we should remove it.

@Ki-er Ki-er changed the title Exclude Dnote (Simple / No maintenance required) Remove Dnote (Unmaintained since July 2024) Jul 7, 2025
Copy link
Collaborator

@kokomo123 kokomo123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no problems here.

@nodiscc nodiscc removed the reviewers wanted Awaiting reviews label Jul 7, 2025
@Ki-er Ki-er merged commit 51deb5e into awesome-selfhosted:master Jul 12, 2025
1 check passed
@Ki-er Ki-er deleted the exclude-dnote branch July 12, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
curation Removal of abandoned projects, dead links
Development

Successfully merging this pull request may close these issues.

4 participants