Integrate libremidi for real MIDI device enumeration #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add libremidi dependency using FetchContent in root CMakeLists.txt - Link libremidi to midi-ci-tool-lib target - Replace hardcoded device lists in MidiDeviceManager with real libremidi enumeration - Update SettingsWidget to use actual device enumeration from MidiDeviceManager - Add proper device selection callbacks that configure MIDI transport layer - Support cross-platform MIDI 1.0 and 2.0 devices through libremidi - Add error handling for device enumeration failures Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate libremidi for real MIDI device enumeration
This PR integrates the libremidi library to replace hardcoded MIDI device lists with real cross-platform MIDI device enumeration in the qt5-ci-tool application.
Changes Made
CMake Integration
MidiDeviceManager Updates
SettingsWidget Integration
Features
Testing
Note: Local testing was limited due to CMake not being available in the development environment. CI validation will confirm the build works correctly.
Implementation Reference
Implementation follows patterns from ktmidi-ci-tool application in the ktmidi repository, specifically the MidiDeviceManager device enumeration approach.
Link to Devin run: https://app.devin.ai/sessions/ea4a3f80fe804aba82963b442f593d06
Requested by: Atsushi Eno (atsushieno@gmail.com)