Fix typedef compilation errors in Flutter CI tool wrapper #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… conflicts with struct names - Changed typedef struct CIToolRepositoryHandle* CIToolRepositoryHandle to CIToolRepository - Changed typedef struct CIDeviceManagerHandle* CIDeviceManagerHandle to CIDeviceManager - Changed typedef struct CIDeviceModelHandle* CIDeviceModelHandle to CIDeviceModel - Changed typedef struct MidiDeviceManagerHandle* MidiDeviceManagerHandle to MidiDeviceManager - Updated all function signatures in both header and implementation files to use new typedef names - Resolves clang compilation error: typedef redefinition with different types Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typedef compilation errors in Flutter CI tool wrapper
This PR fixes clang compilation errors in the Flutter CI tool's native wrapper where typedef alias names were identical to struct names, causing "typedef redefinition with different types" errors.
Problem
The clang compiler was failing with typedef redefinition errors:
Solution
Renamed all typedef aliases to be distinct from their struct names:
typedef struct CIToolRepositoryHandle* CIToolRepositoryHandle;→typedef struct CIToolRepositoryHandle* CIToolRepository;typedef struct CIDeviceManagerHandle* CIDeviceManagerHandle;→typedef struct CIDeviceManagerHandle* CIDeviceManager;typedef struct CIDeviceModelHandle* CIDeviceModelHandle;→typedef struct CIDeviceModelHandle* CIDeviceModel;typedef struct MidiDeviceManagerHandle* MidiDeviceManagerHandle;→typedef struct MidiDeviceManagerHandle* MidiDeviceManager;Files Changed
tools/flutter-ci-tool/native/ci_tool_wrapper.h- Updated typedef declarations and all function signaturestools/flutter-ci-tool/native/ci_tool_wrapper.cpp- Updated all function implementations to use new typedef namesVerification
✅ Compilation Success:
cmake -B build && cmake --build buildcompletes successfully✅ No typedef errors: Clang no longer reports typedef redefinition errors
✅ Consistent naming: All function signatures updated consistently across header and implementation files
This resolves the compilation issues preventing the Flutter CI tool from building with clang.
Link to Devin run: https://app.devin.ai/sessions/6bfc62593a544e84b097a8d8d38710fa
Requested by: Atsushi Eno (atsushieno@gmail.com)